Draft
Conversation
JaceCear
requested changes
Feb 16, 2026
Collaborator
JaceCear
left a comment
JaceCear
left a comment
There was a problem hiding this comment.
I have not looked at the rendering code.
Otherwise, please adjust/discuss! :)
| // Handle horizontal and vertical tile flipping | ||
| if (entry & (1 << 10)) | ||
| tileX = (TILE_WIDTH - 1) - tileX; // H-flip | ||
| tx = 7 - tx; |
Collaborator
There was a problem hiding this comment.
Using magic numbers instead of TILE_WIDTH is less explicit.
freshollie
commented
Feb 22, 2026
| #define getBlueChannel(x) (((x) >> 10) & 0x1F) | ||
| #define COLOR_OPAQUE 0x8000 | ||
|
|
||
| static inline uint16_t alphaBlendColor(uint16_t targetA, uint16_t targetB, unsigned int eva, unsigned int evb) |
freshollie
commented
Feb 24, 2026
| // (u16 should be plenty for screen coordinates, right?) | ||
| #if !defined(DISPLAY_HEIGHT) | ||
| #error DISPLAY_HEIGHT not defined. | ||
| #if !defined(WIDESCREEN_HACK) && !PLATFORM_GBA |
Collaborator
Author
There was a problem hiding this comment.
This needs to be applied if we have widescreen hack on, since the winreg register size increases
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.